I recently started contributing to WP eCommerce. It’s only really been 2 weeks, but I’ve noticed something.
Lots of issues with no pull requests.
I’ve found 3 or 4 tickets from solid developers (selling premium WPEC products) that have no pull request attached. So they are mentioning an issue or complaining, but not taking the next step of fixing it.
I’ve found this to be true on my small projects on Github as well. People will tell me about bugs, but fix them? Nope.
Being a good member of the development community is more than just creating that issue. If you’re submitting an issue and have any coding skills take the time to put together a pull request as well.
4 responses to “Issues with No Pull Requests”
Really great points. Not only is it a great thing to do – but it also helps the person submitting the pull request learn more about how to collaborate, and they’ll often come out with improved development skills because they’ll have a lot more eyes on their code. Good stuff!
Absolutely. I’ve only added comments and really basic fixes to WPEC, but I have found a bunch of things in WordPress and WPEC that I didn’t know existed before. I’ve learned a lot, despite contributing really basic stuff.
Yup, totally agree. It’s more prevalent in the PHP community though (as opposed to Ruby/Node).
That has been my experience as well. With the WordPress community (which is the portion I have the most knowledge of) I think that stems from WordPress being used as more of a ‘blog’ platform till recently. As we’ve seen more people do bigger things with WordPress, I’m seeing more talk about code quality and more contributions.